Nautilus plugin doesn't links against libnautilus-extension

[GoogleCodeExporter]

The generated libgnome-mplayer-properties-page.so file only links against libc.
This is a problem in the RPM generation since rpm extracts dependency
information from the DT_NEEDED entries of ELF files.

The attached patch adds the missing library dependencies using libtool in
the process (there was already a "-avoid-version" LDFLAG that did nothing
since that's a libtool specific option).

Original issue reported on code.google.com by Christia...@gmail.com on 2 May 2010 at 9:17

Attachments:

• gnome-mplayer-0.9.9.2-missing_DT_NEEDED.patch

[GoogleCodeExporter]

Libs added, but did not convert the plugin to libtool setup.

Original comment by kdeko...@gmail.com on 3 May 2010 at 2:11

• Changed state: Fixed

[GoogleCodeExporter]

Ok, no problem. After I submitted this I saw you removed libtool intentionally.

Still there are other parts of the patch that could be used:
- Why configure.in has PKG_CHECK_MODULES(GTK, [gtk+-2.0 glib-2.0 gthread-2.0])?
* If gtk+-2.0 requires glib-2.0 and gthread-2.0 it should be specified in its 
own .pc
file.
* As is now the gthread-2.0 one adds a "-pthread" CFLAG, that ends adding an 
unneeded
link entry to the generated libgnome_mplayer_properties_page.so file. And 
--as-needed
can't remove the "-pthread" as it can with "-lpthread".

- No real difference, but if the *_LIBS have been added to LIBADD, the *_CFLAGS
should be also added to CFLAGS.

- If libtool isn't used, the "-avoid-version" LDFLAGS is unneeded.

Original comment by Christia...@gmail.com on 3 May 2010 at 4:38

[GoogleCodeExporter]

I wanted to be sure that all the parts for GTK were installed and for gthread, 
that
is any easy way to do it. There is no good reason to split them out. We use 
gthread
in the nautilus plugin, so what ever it wants should be in there. 

I have added the includes, but it really didn't seem to need them.

Original comment by kdeko...@gmail.com on 3 May 2010 at 5:59

[GoogleCodeExporter]

> We use gthread in the nautilus plugin

Not really, it's only used in gnome-mplayer. But if you have plans to start 
using it ok.

Original comment by Christia...@gmail.com on 3 May 2010 at 7:12