mario0alberto1 / gnome-mplayer

Automatically exported from code.google.com/p/gnome-mplayer
0 stars 0 forks source link

v1.0.3 - can't scrub using time slider/bar + size issue on replay (related to "disable embedded player scaling") #506

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Apparently, the new "Disable embedded player scaling" seems to have introduced 
some problems, at least on my system.  Specifically, when playing NON-embedded 
content (i.e. when using gnome-mplayer directly), I will get no video at all if 
"Disable embedded player scaling" is _disabled_.  If the checkbox is _enabled_, 
then I will see video, but I cannot use the time slider/bar to scrub to 
different points in the video.  If I try to use the slider, the video stops 
playing, and when I click "play" again, it will re-scale to a smaller size!

What steps will reproduce the problem?
1. UNCHECK the "disable embedded player scaling" preference.
2. Within gnome-mplayer (not embedded, but launched manually), open any video - 
notice that there is no video.  (This is not codec-dependent; the same results 
occur for MOV, WMV, F4V, etc.)
3. ENABLE the "disable embedded player scaling" preference, and relaunch the 
movie.
4a. Click in the time bar to try to jump to a different point in the video - 
the video will restart instead of jumping to the desired point.
4b. Try using the slider to scrub through the video - the video will stop.
4b_1. Now, click play again... the video restarts but in a smaller scaling!

What is the expected output? What do you see instead?
2. Regardless of the "disable embedded player scaling" preference, I expect to 
see video - this preference should have no effect when running gnome-mplayer as 
a standalone app.  If the box is UNchecked, no video displays.  If the box is 
checked, video will display.

4a. I expect to jump to the desired location in the movie; instead, the movie 
will restart from the beginning.

4b. I expect to be able to scrub through the movie; instead, the movie stops 
playing.

4b_1. I expect that the movie will restart with the same scaling, but instead, 
the movie plays at a smaller scaling.

What version of the product are you using? On what operating system?
Using gnome-mplayer v1.0.3, freshly compiled, on CentOS 5.2.
If it matters, also using mplayer SVN20100129, GTK+ 2.14.7, Glib 2.18.4.

Please provide any additional information below.
Note that gnome-mplayer v0.9.8 did _not_ suffer from this problem, thus this 
bug was introduced sometime between that 0.9.9 and 1.0.3.  gnome-mplayer 0.9.8 
still works just fine using the exact same mplayer, GTK+, and Glib libraries, 
so the issue is not with the external binaries directly (though it may be some 
incompatibility between gnome-mplayer v1.0.3 and these external binaries).

Also note that scrubbing using the mouse scroll wheel _DOES_ work, even though 
dragging the time slider does not.

Let me know if you need any more info.
Thanks.

Original issue reported on code.google.com by aca...@gmail.com on 26 Apr 2011 at 12:18

GoogleCodeExporter commented 8 years ago
I should clarify that this is using local movie files, not streaming internet 
files, hence the jumping around should explicitly work just fine (and does, in 
v0.9.8).

Original comment by aca...@gmail.com on 26 Apr 2011 at 12:20

GoogleCodeExporter commented 8 years ago
between 0.9.9 and 1.0.3 there were probably 1000 changes made to the code. So 
that is a lot to isolate. If you could narrow it down that would help.

If you press CTRL-1 does the picture appear?
I might suggest upgrading to a newer mplayer.

Original comment by kdeko...@gmail.com on 26 Apr 2011 at 12:37

GoogleCodeExporter commented 8 years ago
I realized there was a big version gap; I'm happy to provide any more info 
and/or do as much more testing as you need.

Pressing CTRL-1 does make the picture appear, yes.  In fact, any resizing of 
the window (even via mouse) will make the picture appear.  However, the 
rescaling has to be done (whether by keyboard or mouse) - the picture will not 
appear when the movie is first started, but only after the window is resized.

I will try a newer version of mplayer as soon as I can - I need to find some 
time to compile it.

(I also noticed that using the menu resizing - e.g. half size, normal size, or 
double size - will resize the window to take up all available vertical space, 
leaving huge black bars above and below the picture; the picture is sized 
correctly, but the window is not.  Horizontally, the window is scaled 
appropriately.  v0.9.8 doesn't do this - the window resizes appropriately both 
vertically and horizontally.  Should I file that as a separate bug?)

Original comment by aca...@gmail.com on 27 Apr 2011 at 1:41

GoogleCodeExporter commented 8 years ago
I'm redoing all that code this week, so no need to open a bug for now. I am 
replacing the mplayer backend with all new code.

Original comment by kdeko...@gmail.com on 27 Apr 2011 at 3:54

GoogleCodeExporter commented 8 years ago
Looks like I can't compile a new version of mplayer right now because of a 
compile error - I'm getting a fatal error in libmpcodecs/vd_ffmpeg.c.  No idea 
why - the code is from today's SVN checkout of both mplayer and ffmpeg.  I will 
have to wait a bit to see if they fix that problem.

However, I suspect the underlying issue for the primary bug isn't specifically 
with mplayer, since it appears to be an interface issue with gnome-mplayer.  
(If mplayer were the problem, wouldn't gnome-mplayer v0.9.8 suffer from the 
same issues?  Maybe not, but it seems logical.)

I'll try your newer version whenever you recommend.

Original comment by aca...@gmail.com on 27 Apr 2011 at 4:01

GoogleCodeExporter commented 8 years ago
The "video not displaying" bug may be somewhat intermittent... after much more 
extensive testing, it appears that sometimes the video will not display even 
when the checkbox is enabled, and sometimes the video _will_ display even when 
the checkbox is disabled.  Thus, it may be that the non-display issue is not 
completely related to the "embedded scaling" preference, although there does 
seem to be some relation since the video is more likely to display when scaling 
is disabled (checkbox enabled).  Of course, this just makes things even more 
difficult, since intermittent issues are a real pain to track down!

The time slider/bar issue is completely repeatable, not intermittent.

I also managed to compile a newer version of mplayer, SVN-2011-04-19 (after a 
lot of trouble - despite mplayer's insistence on using the git snapshot for 
ffmpeg, recent changes to ffmpeg required the use of an older release, and I 
also had to manually fix a bug in mplayer's configure script which failed to 
check for trunc and thus failed to set HAVE_TRUNC, needed by ffmpeg.  Yeesh!).  
The newer version of mplayer has no effect on any of the bugs reported here - 
the video display issue still exists intermittently, and the time bar/slider 
issue still exists (repeatably, not intermittently).  The resizing issue also 
remains.

So, unfortunately, mplayer itself doesn't appear to be the culprit.

Let me know what other tests you need.  Thanks.

Original comment by aca...@gmail.com on 28 Apr 2011 at 1:22

GoogleCodeExporter commented 8 years ago
Can you test gnome-mplayer from SVN, some fixes were made in this code that 
should correct the problems you were having.

Original comment by kdeko...@gmail.com on 30 Apr 2011 at 9:23

GoogleCodeExporter commented 8 years ago
I'm traveling this week so may not have time, but I'll test it as soon as I can 
and get back to you.  Thanks.

Original comment by aca...@gmail.com on 30 Apr 2011 at 9:26

GoogleCodeExporter commented 8 years ago
Were you ever able to retest this?

Original comment by kdeko...@gmail.com on 10 May 2011 at 8:30

GoogleCodeExporter commented 8 years ago
I only just returned home yesterday; I'll give it a shot this week and get back 
to you.  Thanks.

Original comment by aca...@gmail.com on 10 May 2011 at 8:32

GoogleCodeExporter commented 8 years ago
Er... well, I just tried compiling an SVN version, and got a few compiler 
errors:

gui.o: In function `player_attribute_changed_callback':
src/gui.c:5886: undefined reference to `gtk_menu_item_get_label'
src/gui.c:5864: undefined reference to `gtk_menu_item_get_label'
gui.o: In function `audio_track_select_callback':
src/gui.c:5743: undefined reference to `gtk_menu_item_get_label'
libgmtk/libgmtk.a(libgmtk_a-gmtk_media_player.o): In function `thread_reader':
src/libgmtk/gmtk_media_player.c:2544: undefined reference to 
`gtk_widget_get_allocation'
libgmtk/libgmtk.a(libgmtk_a-gmtk_media_player.o): In function 
`gmtk_media_player_init':
src/libgmtk/gmtk_media_player.c:232: undefined reference to 
`gtk_widget_set_has_window'
src/libgmtk/gmtk_media_player.c:233: undefined reference to 
`gtk_widget_set_can_focus'
src/libgmtk/gmtk_media_player.c:234: undefined reference to 
`gtk_widget_set_can_default'

I don't get these errors when compiling v1.0.3, using the exact same setup.  (I 
don't pass any flags to ./configure except for a --prefix.)

Looks like some of the SVN changes may have broken compatibility with my setup, 
I guess, so I can't compile it at the moment.

Original comment by aca...@gmail.com on 12 May 2011 at 2:08

GoogleCodeExporter commented 8 years ago
I'll see if I can fix those. Centos 5.2 is pretty old, I do have a CentOS 5.6 
machine available to me. I'll see if I can get it to work there.

Original comment by kdeko...@gmail.com on 12 May 2011 at 12:38

GoogleCodeExporter commented 8 years ago
Ok, current SVN should compile on your machine now.

Original comment by kdeko...@gmail.com on 12 May 2011 at 1:09

GoogleCodeExporter commented 8 years ago
I just tried compiling SVN again (checked out 5 minutes ago) and got a 
different error this time...

/usr/bin/msgfmt: ug.po: field `Last-Translator' still has initial default value
/usr/bin/msgfmt: found 1 fatal error
make[2]: *** [ug.gmo] Error 1

I fixed it manually by entering some non-default info into that field, and 
compilation then succeeded.

The "no video" issue has been fixed.  However, I still can't scrub in the time 
bar... clicking in the timebar will not switch to that time in the video, and 
dragging the slider also doesn't work.

Additionally, all videos now open with the window taking up ALL vertical space 
(horizontal is scaled appropriately).  I assume this is because you probably 
put in a command to use "Normal" size upon launch... as mentioned in comment 
#3, using any of the menu "size" choices causes the window to take up all the 
available vertical space, leaving huge black bars above and below the movie.  
Horizontally, the window is properly scaled.

One bug down, two to go. =)

Thanks.

Original comment by aca...@gmail.com on 19 May 2011 at 11:07

GoogleCodeExporter commented 8 years ago
Fixed the ug.po problem... ugh stupid reason to fail a build probably got that 
file from Ubuntu, they should know better.

And this happens with all your files? Screenshots and gnome-mplayer -v logs 
appreciated as I do not have either of these issues.

Original comment by kdeko...@gmail.com on 19 May 2011 at 11:23

GoogleCodeExporter commented 8 years ago
Yes, the time-slider issue happens with all movie files.  As does the 
window-size issue.  I can send a screenshot for the window-size issue (will do 
tomorrow), but obviously that won't help with the time-slider issue.  I'll also 
upload some -v logs, though I have no idea if they would help.  I'll get back 
to you tomorrow.

Original comment by aca...@gmail.com on 20 May 2011 at 3:17

GoogleCodeExporter commented 8 years ago
I believe I have fixed the visual seeking when using the time slider in 
gnome-mplayer r2176 + gmtk r48. I guess I was not sure what you meant by 
"scrubbing", but I think that means visual seeking which did not work, but does 
now.

Original comment by kdeko...@gmail.com on 27 Sep 2011 at 5:23

GoogleCodeExporter commented 8 years ago

Original comment by kdeko...@gmail.com on 16 Nov 2011 at 11:12