Segmentation fault under GNOME 3.2

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Update to GNOME 3.2
2. Open GNOME MPlayer
3. Open any video file for playback

What is the expected output? What do you see instead?
The video is expected to be played. Instead, GNOME MPlayer segfaults producing 
the attached backtrace all of the time.

What version of the product are you using? On what operating system?
GNOME MPlayer 1.04 (1.05b is also affected)
Arch Linux (x86_64)

Please provide any additional information below.
GNOME 3.2 (gtk3 3.2.0, glib2 2.30.0, gtk2 2.24.6)
MPlayer rev33161

Original issue reported on code.google.com by unmacaque@gmail.com on 10 Oct 2011 at 7:47

Attachments:

• gnome-mplayer.log

[GoogleCodeExporter]

I believe this patch will fix it...

svn diff
Index: gmtk_media_player.c
===================================================================
--- gmtk_media_player.c (revision 50)
+++ gmtk_media_player.c (working copy)
@@ -2214,7 +2214,8 @@
                 if (player->subtitle_font != NULL && strlen(player->subtitle_font) > 0) {
                     fontname = g_strdup(player->subtitle_font);
                     size = g_strrstr(fontname, " ");
-                    size[0] = '\0';
+                    if (size)
+                        size[0] = '\0';
                     size = g_strrstr(fontname, " Bold");
                     if (size)
                         size[0] = '\0';

Fixed in gmtk svn r53

Original comment by kdeko...@gmail.com on 10 Oct 2011 at 12:46

• Changed state: Fixed

[GoogleCodeExporter]

This almost fixed it. Now, it segfaults at line 2267 in gmtk_media_player.c.

Original comment by unmacaque@gmail.com on 10 Oct 2011 at 2:39

[GoogleCodeExporter]

Another patch, applied to svn r56

svn diff
Index: src/gmtk_media_player.c
===================================================================
--- src/gmtk_media_player.c (revision 55)
+++ src/gmtk_media_player.c (working copy)
@@ -2264,7 +2264,8 @@
             if (player->subtitle_font != NULL && strlen(player->subtitle_font) > 0) {
                 fontname = g_strdup(player->subtitle_font);
                 size = g_strrstr(fontname, " ");
-                size[0] = '\0';
+                if (size)
+                    size[0] = '\0';
                 argv[argn++] = g_strdup_printf("-subfont");
                 argv[argn++] = g_strdup_printf("%s", fontname);
                 g_free(fontname);

Original comment by kdeko...@gmail.com on 10 Oct 2011 at 3:10

[GoogleCodeExporter]

That completely fixed it. Thank you!

Original comment by unmacaque@gmail.com on 10 Oct 2011 at 3:14