patch for gnome-mplayer 1.0.5

[GoogleCodeExporter]

Patch changed dblclick and keys KP_Enter, Enter to fullscreen
keys Up, Down to changed volume.
Keys Left, Right changed value position.

The volume will be different, if the control it with keyboard and mouse wheel.
Patch fix it.

Original issue reported on code.google.com by censureblock on 9 Feb 2012 at 10:28

Attachments:

• gnome-mplayer-1.0.5-keys.patch

[GoogleCodeExporter]

I don't mind some of this patch, but I'm not sure I like that the patch changes 
the default seek positions. The values I currently use match up with the 
defaults of mplayer. Any particular reason you have changed these to lower 
values?

Original comment by kdeko...@gmail.com on 9 Feb 2012 at 10:39

[GoogleCodeExporter]

how am can to change them, if they are written in the code ..
no options in the settings to change them ..

Original comment by censureblock on 10 Feb 2012 at 8:35

[GoogleCodeExporter]

Then we need to make them alterable options, which will be a much larger change.

Original comment by kdeko...@gmail.com on 10 Feb 2012 at 3:25

[GoogleCodeExporter]

I took a look at your patch and decided the following things.

I did not take your change to mouse double click, because it is already in 
there. If you double click button one, the screen will toggle full screen.

I did take the KP_Enter patch, the volume adjustment values for keys GDK_9 & 
GDK_0

I did not change anything else for these reasons

If you want smaller values, the correct option will be to make them 
configuration items. Right now the defaults match the defaults of mplayer, and 
I want to keep it that way. 

The other options either match up with the mplayer defaults or are decisions 
that have been made in the past and at this point there is no reason to change 
them.

SVN r2220 contains the changes

Original comment by kdeko...@gmail.com on 21 Feb 2012 at 1:59

• Changed state: Fixed