libgnome-mplayer-properties-page.so plugin causes nautilus crash

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Install gnome-mplayer-1.0.6 and nautilus (3.0 in my case)
2. Install mplayer2 but not mplayer.
3. Right click on a video file (rmvb, or mkv, in my case)
4. Nautilus crash immediately.

What is the expected output? What do you see instead?
none.

What version of the product are you using? On what operating system?
Gnome-mplayer-1.0.6, mplayer2-2.0_p20120309, nautilus-3.2.1

Please provide any additional information below.
Attach a nautils process with gdb, and then repeat my produces, gdb will give 
output as follows:
""""""
The program being debugged has been started already.
Start it from the beginning? (y or n) y
Starting program: /usr/bin/nautilus 
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
Gtk-Message: Failed to load module "globalmenu-gnome"
[New Thread 0x7fffec530700 (LWP 21567)]
[New Thread 0x7fffebd2f700 (LWP 21568)]
[New Thread 0x7fffeb52e700 (LWP 21569)]
Initializing nautilus-open-terminal extension
[New Thread 0x7fffd9ad1700 (LWP 21570)]
[New Thread 0x7fffd92d0700 (LWP 21571)]
[New Thread 0x7fffd78c2700 (LWP 21572)]
[Thread 0x7fffebd2f700 (LWP 21568) exited]
[Thread 0x7fffd9ad1700 (LWP 21570) exited]
[Thread 0x7fffd92d0700 (LWP 21571) exited]
Error when running: 
执行子进程“mplayer”失败(没有那个文件或目录)

Program received signal SIGSEGV, Segmentation fault.
0x00007fffea2c6d87 in ?? () from 
/usr/lib64/nautilus/extensions-3.0/libgnome-mplayer-properties-page.so
(gdb) backtrace 
#0  0x00007fffea2c6d87 in ?? () from 
/usr/lib64/nautilus/extensions-3.0/libgnome-mplayer-properties-page.so
#1  0x000000000045bd11 in ?? ()
#2  0x0000000000460f10 in ?? ()
#3  0x000000000049a8d4 in ?? ()
#4  0x00007ffff5127a91 in g_main_context_dispatch () from 
/usr/lib64/libglib-2.0.so.0
#5  0x00007ffff5127e45 in ?? () from /usr/lib64/libglib-2.0.so.0
#6  0x00007ffff5127ef4 in g_main_context_iteration () from 
/usr/lib64/libglib-2.0.so.0
#7  0x00007ffff56e6244 in g_application_run () from /usr/lib64/libgio-2.0.so.0
#8  0x000000000042ceed in ?? ()
#9  0x00007ffff468d00d in __libc_start_main () from /lib64/libc.so.6
#10 0x000000000042cf35 in ?? ()
#11 0x00007fffffffe258 in ?? ()
#12 0x00000000ffffffff in ?? ()
#13 0x0000000000000001 in ?? ()
#14 0x00007fffffffe5a6 in ?? ()
#15 0x0000000000000000 in ?? ()
(gdb) quit
""""""

So I opened source file of gnome-mplayer, and found some return value is not 
checked while it should be.

Please refer to the attached patch (patch using "-Np0").

Best regards.

And one more thing: the editor macros in source file sais that TABs should used 
to indent instead of WS(which is now used).

Original issue reported on code.google.com by yangyingchao@gmail.com on 26 Apr 2012 at 12:57

Attachments:

• nautilus_property_page.patch

[GoogleCodeExporter]

Can you please provide the patch without whitespace changes (make indent will 
correct the file to my preferred formatting) as I have lost your changes in the 
noise.

Original comment by kdeko...@gmail.com on 26 Apr 2012 at 5:07

[GoogleCodeExporter]

ok, I see what you did.. I'll patch that manually

Original comment by kdeko...@gmail.com on 26 Apr 2012 at 5:21

[GoogleCodeExporter]

Should be fixed in r2244

Original comment by kdeko...@gmail.com on 26 Apr 2012 at 5:26

• Changed state: Fixed

[GoogleCodeExporter]

Thanks for your work and reply.

Original comment by yangyingchao@gmail.com on 1 May 2012 at 1:08

[GoogleCodeExporter]

Sorry, I was too busy to check and reply this mail.

Thanks for your greate work.

2012/4/27 <gnome-mplayer@googlecode.com>

Original comment by yangyingchao@gmail.com on 1 May 2012 at 4:02