mario0alberto1 / gnome-mplayer

Automatically exported from code.google.com/p/gnome-mplayer
0 stars 0 forks source link

resume playback doesn't work with all locales #683

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Forwarding a bug report from Ubuntu [1]:

"When watching a video and quitting gnome-mplayer, the next time you open
the video it asks you if you want to resume it from the same position.
For example, if you watch a video for the first 30 seconds and quit, the
next time you open the file with gnome-mplayer it puts up a pop-up
asking "Resume playback of <file> at 0:30" pressing yes, nothing
happens.

How this works is that gnome-mplayer passes the position of the video to
mplayer with the -ss command line argument. The problem is, with
LC_NUMERIC set to for example fi_FI.UTF-8 , instead of . is used as a
decimal separator, so what happens is:

GMLIB-Message: ERROR: Option ss: invalid time: '30,000000'
GMLIB-Message: MPlayer2 UNKNOWN (C) 2000-2012 MPlayer Team
GMLIB-Message: ERROR: Error parsing commandline option "-ss": Option parame=
ter could not be parsed"

[1] https://bugs.launchpad.net/bugs/1182874

Original issue reported on code.google.com by s.ramac...@gmail.com on 22 May 2013 at 6:55

GoogleCodeExporter commented 8 years ago
Can you try SVE r2441 of gnome-mplayer and see if that fixes it. It appeared to 
fix it for me.

Original comment by kdeko...@gmail.com on 23 May 2013 at 1:00

GoogleCodeExporter commented 8 years ago
Sure, that should do it. But wouldn't it be better to just use something like 
g_ascii_dtostr to convert that particular float instead of changing the output 
of all floating point values?

Original comment by s.ramac...@gmail.com on 23 May 2013 at 4:47

GoogleCodeExporter commented 8 years ago
Ok, I took your recommendation and rather than using the shotgun approach and I 
backed out the change to gnome-mplayer and applied the change to gmtk to handle 
it value by value. The new changes seem to work well for me.

Original comment by kdeko...@gmail.com on 24 May 2013 at 2:10