search

marioaguzman / toolbar

Programmatically constructing an NSToolbar
MIT License
250 stars 18 forks source link

Backward compatible code is missing #2

Closed tempelmann closed 2 years ago

tempelmann commented 2 years ago

As a developer who likes to keep his code compatible with older macOS versions as much as feasible, it would be nice if your example also includes examples that work on pre-10.15 systems.

Along that, the Readme has a sub title "## macOS Catalina and older", yet the code doesn't work well on pre-Catalina systems. It should also be made clearer that the automatic conversion of a group item into a narrower one with a popup menu only works on Big Sur and later, not in Catalina.

marioaguzman commented 2 years ago

The collapsible segmented control does in fact work in Catalina. When I first wrote this, it was under Catalina. It's there in the screenshots.

I will remove the Catalina mentions in the README. Thanks for letting me know.

tempelmann commented 2 years ago

Huh, in my tests I couldn't get it working in Catalina, but now I see it works with your original code. I must have made a mistake when adding code for supporting pre-10.15 systems as well.

tempelmann commented 2 years ago

I now remember what the problem with 10.15 was: It doesn't work if you want to use icons in the segments. Works only with labels. 11.0 finally allows icons in the segments, with the labels appearing in the popup menus.