mariobuikhuizen / voila-embed-vuetify

A Vue component to embed ipyvuetify widgets served by Voila
MIT License
1 stars 1 forks source link

some material design icons don't render correctly #1

Open havok2063 opened 4 years ago

havok2063 commented 4 years ago

Some of the material design icons do not render correctly inside jdaviz when the application is compiled and embedded with voila-embed-vuetify versus when the application is loaded in a notebook. Likewise there are different icons that do not render correctly using the script method of voila-embed package. In all cases the buttons still work, just the icons do not display.

Voila-Embed-Vuetify

Jupyter Notebook

jdaviz_icons_notebook

Voila-Embed

mariobuikhuizen commented 4 years ago

I see jdaviz still uses some icons from the default icon set of older Vuetify versions. You can add these icons to your project by running: yarn add material-design-icons-iconfont and importing them with: import 'material-design-icons-iconfont';

havok2063 commented 4 years ago

Ok, I'll give that a shot. Is there a recommended new set of icons jdaviz should be switching to? I can create an issue for them.

mariobuikhuizen commented 4 years ago

These icons are still supported in ipyvuetify, but I didn't want to force that dependency on to users of voila-embed-vuetify.

You may still want to replace the older icons of jdaviz to https://cdn.materialdesignicons.com/4.5.95/, so your front-end has load fewer resources.

havok2063 commented 4 years ago

Adding the old icons worked for most them. The gear icon still does not display. Looks like the icon mdi-settings was changed to mdi-cog at some point.

havok2063 commented 4 years ago

To get the last gear icon to display, I needed to install a specific version, yarn add material-design-icons-iconfont@4.0.5

mariobuikhuizen commented 4 years ago

That's strange, because ipyvuetify uses material-design-icons-iconfont@5.0.1 and @mdi/font@4.9.95.

havok2063 commented 4 years ago

That is strange. I installed 5.0.1 at first and that fixed all of them I could see except that one.