search

mariobuikhuizen / voila-embed-vuetify

A Vue component to embed ipyvuetify widgets served by Voila
MIT License
1 stars 1 forks source link

Updating voila-embed component #3

Closed havok2063 closed 2 years ago

havok2063 commented 2 years ago

This PR closes #2 and updates the JupyterWidgetEmbed code with the latest changes from the original voila-embed.js script file in https://github.com/mariobuikhuizen/voila-embed.

Edit: the example now works for me.

mariobuikhuizen commented 2 years ago

@havok2063, I've added a dev install section to the readme: #4. Without the linking, it uses the old version from CDN.

mariobuikhuizen commented 2 years ago

Running the example now fails on lint errors in JupyterWidgetEmbed.js, which it shouldn't lint. I'll look into fixing this.

I locally fixed the lint errors, and your PR works for me.

mariobuikhuizen commented 2 years ago

I've updated the dev install section in #4, which is now a simple copying of files.

mariobuikhuizen commented 2 years ago

Thanks!