search

mariocasciaro / gulp-concat-css

Concatenates css files, bubbling up import statements (as per the standard), and optionally rebasing urls and inlining local import statements.
MIT License
78 stars 19 forks source link

css with base64 #16

Closed b2whats closed 9 years ago

b2whats commented 9 years ago

BEFORE

background: url('data:image/png;base64,iVBORw.......Jggg==') no-repeat scroll 100% 50% rgba(0, 0, 0, 0);

AFTER

background: url(data:image/png;base64,iVBORw.......Jggg==") no-repeat scroll 100% 50% rgba(0, 0, 0, 0);

disappear quotes

mariocasciaro commented 9 years ago

That is still a valid URI (without quotes) unless it contains special characters that must be quoted. Is that creating any problem in your CSS?

b2whats commented 9 years ago

is valid, but because of the quotes in the code editor ceases to be formatted http://joxi.ru/V2VepwBsB4xXmv.jpg

mariocasciaro commented 9 years ago

The screenshot shows that there is an extra quote, which is not right. Will add a unit test to try to reproduce.

feiqitian commented 9 years ago

BEFORE: background: url("data:image/gif;base64,R0lGODlhF...ABAAAIBADpBQQAOw==") no-repeat; AFTER: background: url(data:image/gif;base6,R0lGODlhF...ABAAAIBADpBQQAOw==") no-repeat;

base64 --> base6

mariocasciaro commented 9 years ago

Yes apparently the problem is in the package rework-plugin-function which doesn't parse the url properly. Will try to open a defect send a PR.

mariocasciaro commented 9 years ago

Landend in 2.0.0.