search

mariocasciaro / gulp-concat-css

Concatenates css files, bubbling up import statements (as per the standard), and optionally rebasing urls and inlining local import statements.
MIT License
78 stars 19 forks source link

URL paths are rewritten #25

Open jfairley opened 9 years ago

jfairley commented 9 years ago

I'm not sure the use case for URL rewriting, but it just bit me in an unfortunate way.

Similar to https://github.com/mariocasciaro/gulp-concat-css/issues/1, I'm also using font-awesome, but the paths that are rewritten as the are in the example (minus the slash direction), mess up my output.

So more specifically...

url('../fonts/font-awesome/*')

becomes

url('font-awesome/fonts/font-awesome/*')

I'm curious of the intended use case. Am I supposed to copy the font-awesome fonts to dist/font-awesome/fonts (i.e. dist/<npm-module>/fonts)? IMO, this seems to add too much knowledge into my minification process.

hughgrigg commented 9 years ago

Setting the rebaseUrls option to false is supposed to avoid this, but for me the setting seems to make no difference. URLs are rebased either way.

mariocasciaro commented 9 years ago

@hughgrigg Could you please create a test case for your problem? The tests we have say that the rebaseUrls option should be working properly

Lexa1983 commented 8 years ago

Having the same issue. rebaseUrls flag doesn't make difference.

When I have in src "[ css/reset.css, ...]" URLs are OK (i.e. rebased), when I have "[ plugins/reset.css, ...]" (i.e. just moved that file to another folder) - URLs are not OK.

ZuSe commented 8 years ago

I can confirm this behavior (using v 2.3.0) Any news on it?

trainoasis commented 6 years ago

This still was not touched?