Add option `basedir` for easily specify base directory for URL rebasing.

mariocasciaro / gulp-concat-css

Concatenates css files, bubbling up import statements (as per the standard), and optionally rebasing urls and inlining local import statements.

MIT License

78 stars 19 forks source link

Add option `basedir` for easily specify base directory for URL rebasing. #28

Closed LoicMahieu closed 9 years ago

LoicMahieu commented 9 years ago

Manually overwriting the root directory used for URL rebasing is a common task and for now, there was no easy way to do that. Now we have the basedir option.

mariocasciaro commented 9 years ago

Hi @LoicMahieu , thanks for the PR. Why you want to override the baseDir if it's already available in the vinyl stream (file.base)? It's just convenience or there's something that I'm missing?

LoicMahieu commented 9 years ago

Hi @mariocasciaro Yes it was for convenience but mostly because I was misunderstand the base property in vinyl steam... After this enlightenment I realize that my PR is completely :) Thanks for your response. I close the PR because it's useless ;)