mariocasciaro / gulp-concat-css

Concatenates css files, bubbling up import statements (as per the standard), and optionally rebasing urls and inlining local import statements.
MIT License
78 stars 19 forks source link

Ignore url that contains base64 string #8

Closed mcometa closed 9 years ago

mcometa commented 9 years ago

Any idea why the code below is happening? (pay attention to the "src:url" of the send block)

@font-face {font-family: footable; src: url(data:application/x-font-ttf;base64,AAEAAAANAIAAAwBQRkZUTWX2pJQAABIUAAAAHEdERUYAVAAGAAAR9AAAACBPUy8yL7rbzQAAAVgAAABWY21hcOA289QAAAJMAAABUmdhc3D//wADAAAR7AAAAAhnbHlmHyn2eQAAA/AAAArYaGVhZP2Ldh8AAADcAAAANmhoZWEEEAAIAAABFAAAACRobXR4PX4BLQAAAbAAAACcbG9jYTF0NGIAAAOgAAAAUG1heHAAbABHAAABOAAAACBuYW1lftV6UAAADsgAAAGScG9zdNvKeDUAABBcAAABkAABAAAAAQAA7qsXFl8PPPUACwIAAAAAAM42mrEAAAAAzjaasf///+ACAAHgAAAACAACAAAAAAAAAAEAAAHg/+AALgIA///+AAIAAAEAAAAAAAAAAAAAAAAAAAAnAAEAAAAnAEQAAwAAAAAAAgAAAAEAAQAAAEAAAAAAAAAAAQGuAZAABQAIAUwBZgAAAEcBTAFmAAAA9QAZAIQAAAIABQMAAAAAAAAAAAAAEAAAAAAAAAAAAAAAUGZFZABA4ADwAAHg/+AALgHgACC...);}

is being compiled as:

@font-face{font-family:footable;src:url(admin-user/media/sass/data:application/x-font-ttf;base64,AAEAAAANAIAAAwBQRkZUTWX2pJQAABIUAAAAHEdERUYAVAAGAAAR9AAAACBPUy8yL7rbzQAAAVgAAABWY21hcOA289QAAAJMAAABUmdhc3D/wADAAAR7AAAAAhnbHlmHyn2eQAAA/AAAArYaGVhZP2Ldh8AAADcAAAANmhoZWEEEAAIAAABFAAAACRobXR4PX4BLQAAAbAAAACcbG9jYTF0NGIAAAOgAAAAUG1heHAAbABHAAABOAAAACBuYW1lftV6UAAADsgAAAGScG9zdNvKeDUAABBcAAABkAABAAAAAQAA7qsXFl8PPPUACwIAAAAAAM42mrEAAAAAzjaasf/+ACAAHgAAAACAACAAAAAAAAAAEAAAHg/+AALgIA/+AAIAAAEAAAAAAAAAAAAAAAAAAAAnAAEAAAAnAEQAAwAAAAAAAgAAAAEAAQAAAEAAAAAAAAAAAQGuAZAABQAIAUwBZgAAAEcBTAFmAAAA9QAZAIQAAAIABQMAAAAAAAAAAAAAEAAAAAAAAAAAAAAAUGZFZABA4ADwAAHg/+AALgHgACCAAAABAAAAAAAAAgAAAAAAAAAAqgAAAAAAAAIAAAACAAAAAgAAAAIAAAACAAAAAgAAAAFJAAABSQAAAbYAAAG2AAACAAAAAgAAAAIAAAACAAAAAgAAAAIAAAACAABAAgAAYAEkAAABJAAAALYAEgC2AAACAAAgAgAAIAIAAAACAAAAAgAAAAIAAAACAAAAAgAAAAFJ...);}

I have a number of images and fonts that are encoded as base64 string, can this be ignored when this plugin is run?

gulpfile.js contains:

gulp.task('styles2', function () {

    gulp.src(['modules/**/media/sass/*.scss'])
        .pipe(foreach(function(stream,file){
            var filePath = file.path;
            var fileNameScss = filePath.substring(filePath.lastIndexOf('/')+1);
            var fileCss = gutil.replaceExtension(fileNameScss, '.css');

            return stream
                .on('error', gutil.log)
                .pipe(sass({
                    style: 'expanded'
                }))
                .pipe(concatCss(fileCss))
                .on('error', gutil.log)
                .pipe(csso())
                .on('error', gutil.log)
                .pipe(flatten())
                .on('error', gutil.log)
                .pipe(gulp.dest('./admin/webroot/assets/css/'));

        }));
});
mariocasciaro commented 9 years ago

Thanks for reporting, I'll look into it.

mariocasciaro commented 9 years ago

Landed on 1.0.0