New Settings Page

[Bashamega]

Hello:) I have customized the settings page and integrated it into the website using js. Solves: #137

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
bark-coding	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 11, 2024 6:33am

[breakfast-for-dinner]

heck yeah

[Bashamega]

Will you merge?

On Fri, May 10, 2024, 19:22 qwertyy @.***> wrote:

heck yeah

— Reply to this email directly, view it on GitHub https://github.com/mariocraft987/bark-coding/pull/141#issuecomment-2104886159, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2MJG2JQJS2S5DUY2LKMDTDZBTX3LAVCNFSM6AAAAABHQ3RHCKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBUHA4DMMJVHE . You are receiving this because you authored the thread.Message ID: @.***>

[breakfast-for-dinner]

there's merge conflicts 🥲

[Bashamega]

there's merge conflicts 🥲

For some reason i can't resolve them. Github disabled the button

[Bashamega]

It seems like the JavaScript code isn't complete and organised in the sense of closing the {'s.

Edit: Maybe it might be fine, it might just be because there is a issue merging it.

Yeah in the sense of CSS formatting was bad do i have reformatted it. and added semicolons in my js code.

[Rubiidev-18]

I added more review requesters 👍🏻 also can you make the search bar and text in search bar a lighter ver of the current accent color? the blue looks so bad here. also can you gimme the theme selection snippet of the theme css for future use?

[Bashamega]

I added more review requesters 👍🏻 also can you make the search bar and text in search bar a lighter ver of the current accent color? the blue looks so bad here. also can you gimme the theme selection snippet of the theme css for future use?

This is the code snippet for applying the css:

const theme = localStorage.getItem('theme');
if (theme) {
    if (theme.startsWith('#')) {
        const style = document.createElement('style');
        style.innerHTML = `
        .navbar{
            background:${theme};
        }
        `;
        document.head.append(style);
    } else if (theme != "bluedodger") {
        const link = document.createElement('link');
        link.rel = "stylesheet";
        link.href = `https://bark-coding.vercel.app/src/themes/${theme}.css`;
        document.head.append(link);
    };
};

Would you prefer the placeholder text will be white?

[Rubiidev-18]

yea, it's good.

Would you prefer the placeholder text will be white?

[breakfast-for-dinner]

i resolved the conflicts, should i merge

[breakfast-for-dinner]

"Browndodger" looks really weird.

i couldn't agree more 🤣 "classicblue" was the original theme. i gave the ui a revamp and thus, the bluedodger you see today was born

[Bashamega]

And currently you can't see which theme you have selected.

Would you like me to work on this, i can open a new PR for this

[Bashamega]

And currently you can't see which theme you have selected.

Would you like me to work on this, i can open a new PR for this

Sure, I'd be happy to help as well.

I think it would be easy for me to do it, but if i need help i will mention you

[Bashamega]

And currently you can't see which theme you have selected.

Would you like me to work on this, i can open a new PR for this

Sure, I'd be happy to help as well.

I think it would be easy for me to do it, but if i need help i will mention you

Ok, I don't think you need to make a PR for this. I think you can just contribute to main.

it is done