search

mariodian / bitfinex-api-php

Bitfinex PHP API - Access all features of https://www.bitfinex.com trading platform
Creative Commons Zero v1.0 Universal
31 stars 33 forks source link

Websockets #1

Open joshuarossi opened 8 years ago

joshuarossi commented 8 years ago

This is a really great library! We want to add it to the docs at docs.bitfinex.com, but would it be possible to add support for websockets?

mariodian commented 8 years ago

Hey Joshua thanks!

To tell you do truth I haven't even heard of "client" side websockets up until now. I may be wrong but from what I know about PHP it's by far one of the worst languages to handle open connections for a longer period of time. I assume you'd have to hack a lot of things so you don't run out of resources.

I googled some libraries (Devristo/phpws, Textalk/websocket-php etc) and they are rather complex and often dependent on another libs.

I'm sorry but I don't see myself adding WS support to this lib.

joshuarossi commented 8 years ago

no problem, maybe i could give it a shot? I'll submit a PR if I can get it to work

mariodian commented 8 years ago

Sure no problem. Thanks!