mariogrs / Simfast21

21cm code
16 stars 15 forks source link

unused linked libs #8

Open gijzelaerr opened 7 years ago

gijzelaerr commented 7 years ago

package could avoid a useless dependency if get_densityfield.x epsilonXon.x adjust_halos.x t21.x integrateTempX.x get_SFR.x get_HIIbubbles.x get_nldensity.x xc.x get_halos.x get_velocityfield.x xalpha.x integratexe.x were not linked against libgslcblas.so.0 (they use none of the library's symbols)

package could avoid a useless dependency if get_densityfield.x epsilonXon.x adjust_halos.x t21.x integrateTempX.x get_SFR.x get_HIIbubbles.x get_nldensity.x xc.x get_halos.x get_velocityfield.x xalpha.x integratexe.x were not linked against libpthread.so.0 (they use none of the library's symbols)

mariogrs commented 7 years ago

ok, thanks. we should sit down together at some point and go over the code...

On Mon, Jan 23, 2017 at 10:40 AM, Gijs Molenaar notifications@github.com wrote:

package could avoid a useless dependency if get_densityfield.x epsilonXon.x adjust_halos.x t21.x integrateTempX.x get_SFR.x get_HIIbubbles.x get_nldensity.x xc.x get_halos.x get_velocityfield.x xalpha.x integratexe.x were not linked against libgslcblas.so.0 (they use none of the library's symbols)

package could avoid a useless dependency if get_densityfield.x epsilonXon.x adjust_halos.x t21.x integrateTempX.x get_SFR.x get_HIIbubbles.x get_nldensity.x xc.x get_halos.x get_velocityfield.x xalpha.x integratexe.x were not linked against libpthread.so.0 (they use none of the library's symbols)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mariogrs/Simfast21/issues/8, or mute the thread https://github.com/notifications/unsubscribe-auth/AHlkkyKJx92Y2Go-zQpKC2osKe_UeVE_ks5rVIOMgaJpZM4Lq445 .

mariogrs commented 7 years ago

The first one is sorted but the second one still needs libpthread in the compilation if FFTW as compiled with --enable-threads...

gijzelaerr commented 7 years ago

ideally the build script should figure that out. but again, these warnings are quite harmless so probably it is not worth to effort.

mariogrs commented 7 years ago

well, if you want to help me out configuring the makefile (or point me in the right direction) that would be great...