search

mariohmol / ang-jsoneditor

Angular Jsoneditor that works with angular 4 to angular 15
https://stackblitz.com/edit/angular-json-editor
MIT License
155 stars 89 forks source link

feat: update to angular V17 #129

Open sheikalthaf opened 10 months ago

sheikalthaf commented 10 months ago
sheikalthaf commented 10 months ago

@mariohmol can you review this PR

mariohmol commented 8 months ago

this looks great, thanks @sheikalthaf

will take a look on that tonight

gasparbarancelli commented 7 months ago

Need some help with proofreading? I believe that many users are waiting for the release of their component for Angular 17

tcseh commented 7 months ago

@mariohmol have you had a chance to take a look at this? We depend on this library and would love to update to the latest Angular :)

sheikalthaf commented 7 months ago

@gasparbarancelli @tcseh @mariohmol I see lots of users are waiting for V17 support, I just published the V17 in npm https://www.npmjs.com/package/@ngu/jsoneditor . @mariohmol If you like i can maintain the library and publish the packages in future.

Sathyaraj06 commented 4 months ago

Is this PR Approved? Can we implement for angular 17 application if possible?

on3dd commented 4 months ago

Please merge it already 🙏🏻

samantha-swift commented 3 months ago

Is there any progress on merging this PR? Desperately need V17 support for our prod application

pierakim commented 3 months ago

Please merge it. Thks. 👀

dails08 commented 2 days ago

@gasparbarancelli @tcseh @mariohmol I see lots of users are waiting for V17 support, I just published the V17 in npm https://www.npmjs.com/package/@ngu/jsoneditor . @mariohmol If you like i can maintain the library and publish the packages in future.

Yeah, seems dead. Thanks for the offer to pick it up. Probably oughta just fork it, post your fork here so people coming here know where to find the living version of the library, and we'll all slowly shift over.

sheikalthaf commented 2 days ago

@dails08 I have already published the package to npm and also going to maintain it for furthur also

https://www.npmjs.com/package/@ngu/jsoneditor

dails08 commented 2 days ago

@dails08 I have already published the package to npm and also going to maintain it for furthur also

https://www.npmjs.com/package/@ngu/jsoneditor

Oh wow, I totally missed that. Thank you!

dails08 commented 2 days ago

@dails08 I have already published the package to npm and also going to maintain it for furthur also

https://www.npmjs.com/package/@ngu/jsoneditor

I'm having some issues using your published version. I don't seem to be able to create an issue on the repository; is there a way you'd like feedback provided?

sheikalthaf commented 2 days ago

@dails08 I have already published the package to npm and also going to maintain it for furthur also https://www.npmjs.com/package/@ngu/jsoneditor

I'm having some issues using your published version. I don't seem to be able to create an issue on the repository; is there a way you'd like feedback provided?

@dails08 now i have enabled the issues now. can you log now