mariohock / Chatty

Bidirectional XMPP communications for Home-Assistant's AppDaemon
BSD 2-Clause "Simplified" License
1 stars 2 forks source link

OMEMO support #2

Open meisterlampe opened 4 years ago

meisterlampe commented 4 years ago

I added omemo support using slixmpp_omemo. I basically integrated their example ( link ) into Chatty with their help. This is my repo: https://github.com/meisterlampe/Chatty/tree/omemo For now it is not really a security feature, because no keys are checked. But for me it is a starting point.

It has the following behaviour:

If you are interested in a Pull Request I can create one. I'm quite sure you will find things to optimize though :-D

meisterlampe commented 4 years ago

The main goal I want to achieve by using OMEMO is, that only authorized clients should be able to send commands to chatty.

mariohock commented 4 years ago

This is great. Thank you for your efforts. Pull requests are very welcome. However, it's currently quite hard for me to find some free time to work on Chatty. So I'm not quite sure how long it will take me to review and merge the pull request. Also, since OMEMO brings quite some complexity, I would prefer to integrate it in a way that hides this complexity as much as possible and to keep the "onboarding" for new Chatty users as simple as possible.

Neustradamus commented 4 years ago

Can you update the XEP-0384: OMEMO Encryption support to 0.4.0+ which breaks all?

PS : Not sure that 0.3.0 was complete before.

meisterlampe commented 4 years ago

Omemo Support is managed by slixmpp-omemo which itself uses python-omemo. So I think you have to reach out to them.