mariokreitz / pokedex-v2

A project focused on implementing and showcasing the PokeAPI v2, providing a comprehensive and interactive platform for exploring Pokémon data, including species, abilities, moves, and more.
https://pokedex.mario-kreitz.dev/
MIT License
2 stars 1 forks source link

Good First Issue: Radar Chart Customization and Design Tweaks #3

Open mariokreitz opened 2 months ago

mariokreitz commented 2 months ago

Good First Issue: Radar Chart Customization and Design Tweaks

Description: We need help with customizing and improving the design of the radar chart in the Pokedex-v2 project. This is a great opportunity for newcomers to get familiar with our charting library and contribute to enhancing the visual appeal and functionality of the radar chart.

Task Details:

Requirements:

Resources:

How to Get Started:

  1. Fork the Repository: Click the "Fork" button at the top right of the repository page.
  2. Clone Your Fork: Clone your fork to your local machine using git clone.
  3. Create a Branch: Create a new branch for your changes. For example: git checkout -b radar-chart-customization.
  4. Make Your Changes: Apply the necessary design tweaks and customizations to the radar chart.
  5. Submit a Pull Request: Push your changes and submit a pull request to the main repository.

Additional Notes:

Labels:

ferracioli commented 1 month ago

Hi, was this issue already fixed? I would like to start contributing with open source, and I found out the popup doesn't renders properly in my notebook(1366 x 720px screen). Since the overview-card has a height of 700px, I think it is rendering above my browser window. Below is the representation showing the popup in my screen: image

mariokreitz commented 1 month ago

Hi, was this issue already fixed? I would like to start contributing with open source, and I found out the popup doesn't renders properly in my notebook(1366 x 720px screen). Since the overview-card has a height of 700px, I think it is rendering above my browser window. Below is the representation showing the popup in my screen: image

Hey, this issue with the chart isnt fixed.

THe issue what you are facing is a different one. The overall height from the popupcard is fixed to 700px on the desktop view. I didnt testet it on this resolution that you have =) so the css need some refactoring

ferracioli commented 1 month ago

Great :)

I am going to fork in order to refactor the css(opening a new issue in order to keep this older one), and so will pull request as soon as possible, thanks! Since I am learning the code, it may take some time, but I intend to add a portuguese translation in the Pokedex as well in the future.