Support for MQTT Username/Password and Enable/Disable Buzzer

mariolukas / Watterott-CO2-Ampel-Plus-Firmware

Firmware for Watterott CO2 Ampel (Plus Version)

GNU General Public License v3.0

15 stars 13 forks source link

Support for MQTT Username/Password and Enable/Disable Buzzer #6

Closed reibuehl closed 3 years ago

reibuehl commented 3 years ago

I added support for MQTT Username and Password, configuration posibilities for it and MQTT Base Topic and a method to enable/disable the Buzzer from the configuration page for silent operation.

This pull request implements https://github.com/mariolukas/Watterott-CO2-Ampel-Plus-Firmware/issues/2

loelkes commented 3 years ago

Credentials are stored but never used, see both NULL parameters.

https://github.com/reibuehl/Watterott-CO2-Ampel-Plus-Firmware/blob/1ef925558b169f4f2c5e2e8d7093dc8207e6a696/CO2-Ampel_Plus/MQTTManager.cpp#L19

I've built upon your commits since you've already done most of the work and added the missing part in PR #8. I would recommend dropping this one.

reibuehl commented 3 years ago

Yes, you are correct... I overlooked that.