search

mariomac / microemu

Automatically exported from code.google.com/p/microemu
0 stars 0 forks source link

RecordEnumerationImpl.rebuild() does not filter properly #15

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
In my debugger I have seen the filter comparing the same record repeatedly.
I believe in the case where the filter matches data, you should increment
the recordId.

RecordEnumerationImpl.java, line 194:

if (filter != null && !filter.matches(data)) {
recordId++; // <----- Add this
continue;
}

Original issue reported on code.google.com by bar...@gmail.com on 18 Nov 2009 at 11:47

GoogleCodeExporter commented 8 years ago 
I meant to say: "in the case where there is a filter and it does not match
the data, you should still increment the recordId. Otherwise the same
recordId will be used repeatedly."

Original comment by bar...@gmail.com on 18 Nov 2009 at 11:47

GoogleCodeExporter commented 8 years ago 
Fixed by Issue 23 patch

Original comment by bar...@gmail.com on 8 Jan 2010 at 11:39