mariomulansky / PySpike

Python implementation of spike distance metrics
http://mariomulansky.github.io/PySpike
Other
71 stars 30 forks source link

Fixed bug in distances.py when calculating pairs from arbitrary indices #1

Closed richardtomsett closed 9 years ago

richardtomsett commented 9 years ago

Hi Mario,

I was using PySpike to calculate the SPIKE distance for 9 groups of 100 neurons, with indices 0-899. I think there was a problem when calculating the SPIKE distance when not starting from index 0 with the original implementation, which should be fixed here. It works on my data but I haven't tested it extensively.

Cheers!

Richard

mariomulansky commented 9 years ago

Thanks a lot! I've added some test cases for this to the unit tests and your fix did solve the problem.

richardtomsett commented 9 years ago

Cool! Thanks again for the great library,

Richard

On 23 January 2015 at 00:21, Mario Mulansky notifications@github.com wrote:

Thanks a lot! I've added some test cases for this to the unit tests and your fix did solve the problem.

— Reply to this email directly or view it on GitHub https://github.com/mariomulansky/PySpike/pull/1#issuecomment-71036362.