search

mariomulansky / PySpike

Python implementation of spike distance metrics
http://mariomulansky.github.io/PySpike
Other
71 stars 30 forks source link

Incorrect integrals for PieceWiseLinFunc (and possibly DiscreteFunc too) #37

Closed jonathanjouty closed 5 years ago

jonathanjouty commented 6 years ago

Didn't think to have a look at the other function classes, but seems to be similar issues as with #33, that it doesn't deal well with certain edge cases.

mariomulansky commented 6 years ago

PieceWise Linear likely has a similar issue. For DiscreteFunction, an integral between "support points" doesn't really make sense, and should probably just return 0. However, I'm not sure what the code does right now, worth having a look :)

mariomulansky commented 5 years ago

Closed as duplicate of https://github.com/mariomulansky/PySpike/issues/38