search

mariomulansky / PySpike

Python implementation of spike distance metrics
http://mariomulansky.github.io/PySpike
Other
71 stars 30 forks source link

PySpike incompatible with Python 3.10 #52

Closed gspr closed 2 years ago

gspr commented 2 years ago

Python 3.7 started issuing a warning that importing abstract base classes like Sequence from collections instead of collections.abc is deprecated. With Python 3.10, doing so is an error. That means that PySpike does not work with Python 3.10 or later. That should be fixed, and doing so should be easy.

More info e.g. here.

gspr commented 2 years ago

PR 53 fixes the issue, but may result in incompatibilities with some very old Python versions. If you wanna retain compatibility with those, the PR can be adapted to try both the old and the new import.

gspr commented 2 years ago

The merging of PR 53 fixes this.

mariomulansky commented 2 years ago

Thanks for the PR @gspr - I decided to drop Python2 support and anything older than Python 3.7.