Ej bfixes

[EdmundButler]

You can test the change (warning on no Cython) as follows: git clone https://github.com/mariomulansky/PySpike.git -b EJBfixes pip uninstall cython python setup.py build_ext --inplace

you should get a chance to cancel Later: pip install cython python setup.py build_ext --inplace should just work

[EdmundButler]

Revised test directions: git clone https://github.com/mariomulansky/PySpike.git -b EJBfixes pip uninstall cython rm pyspike/cython/*.c python setup.py build_ext --inplace

[EdmundButler]

Thomas

Odd about not seeing the prompt. If you get a chance, please type: grep input setup.py in the installation folder - you should see the prompt.

I will comment the prompt out, in case anyone decides they want it in the future (I would.)

Otherwise I think that one should be closed. I will update setup.py and also the fix for 41/45. Hopefully all three can be closed shortly.

Will send email with small test program for the #45 fix (I haven't figure out how to upload a test program to github.)

   Ed

------ Original Message ------ From "thomaskreuz" @.> To "mariomulansky/PySpike" @.> Cc "Edmund Butler" @.>; "Author" @.> Date 1/5/2023 9:58:55 AM Subject Re: [mariomulansky/PySpike] Ej bfixes (PR #66)

@thomaskreuz commented on this pull request.

Is the prompt in setup.py still included? I did not encounter it and I think it would be better without.

— Reply to this email directly, view it on GitHub https://github.com/mariomulansky/PySpike/pull/66#pullrequestreview-1237535569, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALRFQNUBJIY5KDVZ3SN2XELWQ3OS7ANCNFSM6AAAAAATQE6X2E. You are receiving this because you authored the thread.Message ID: @.***>

[EdmundButler]

TestReconcile.py.txt

The reconcile_spike_trains() function can be tested by the TestReconcile.py script. (Had to add a .txt to get github to accept it; please rename!)