search

mariomulansky / PySpike

Python implementation of spike distance metrics
http://mariomulansky.github.io/PySpike
Other
71 stars 30 forks source link

Make numpy_include conform to os.PathLike #68

Closed da-woods closed 4 months ago

da-woods commented 1 year ago

This is necessarily to support Cython 3. Cython 3 ends up passing the numpy_include instance directly to os.path.join Making numpy_include behave like an os.PathLike should allow os.path.join to work

mariomulansky commented 4 months ago

Thank you for the fix! The PR was quite old by now (sorry for not merging this earlier), so I re-created the change in another PR myself (#81) in order to confirm the validity of the fix in CI and merged that one.