search

marionebl / svg-term-cli

Share terminal sessions via SVG and CSS
MIT License
3.52k stars 118 forks source link

Comment colour not showing #17

Closed lukechilds closed 6 years ago

lukechilds commented 6 years ago

Hi, me again :)

In my shell (zsh) I have comments enabled. These show up light grey in my terminal, however svg-term outputs them as dark black. Seems like it's just falling back to the default SVG fill colourI because it can't detect it. Is there a way to fix this?

Currently manually adding fill="#645240" to the root SVG element to resolve the problem.

lukechilds commented 6 years ago

For example, this is my terminal: https://i.imgur.com/DSeOCee.mp4

And this is what svg-term produces:

marionebl commented 6 years ago

Thanks for reporting, this should be fixed via https://github.com/marionebl/svg-term/commit/551c4ddc0ca77647574ef104973f663c7587ac20.

Make sure to have the latest svg-term transitive dep by:

npm remove -g svg-term-cli
npm install -g svg-term-cli
marionebl commented 6 years ago

The result I get for with all latest versions:

svg-term --cast RjJDZRRUESBCnPko2Qh1jd6CS --term hyper --window --out examples/chest.svg

lukechilds commented 6 years ago

Ah, I think GitHub's CDN had an old version cached which led to some confusion. Thanks again!