search

marionebl / svg-term-cli

Share terminal sessions via SVG and CSS
MIT License
3.57k stars 118 forks source link

Window icons too large for small terminals #24

Closed adius closed 6 years ago

adius commented 6 years ago

bug

marionebl commented 6 years ago

Please provide the command + cast to reproduce

adius commented 6 years ago

https://asciinema.org/a/YsboQmbF6dA5KcJnx7rxJhLlv

svg-term --cast YsboQmbF6dA5KcJnx7rxJhLlv  --no-cursor --at 99999  --window > bug.svg
marionebl commented 6 years ago

The used asciicast is very wide:

{
  "width": 318,
  "height": 77
}

The window traffic lights scale relative to the window width, this reveals they should clamp to a max-size.

Edit: Scaling them automatically might be a bad idea overall. Might want to have them fixed and allow users to configure the size? Will have to think about this.

adius commented 6 years ago

Yeah I think it should definitely have a fixed size (just like in real windows =P). Allowing the users to change the size sounds cool too (Although I don't really know why someone would want to use that ^^)

marionebl commented 6 years ago

Fixed via version 1.1.5 of svg-term