search

marionebl / svg-term-cli

Share terminal sessions via SVG and CSS
MIT License
3.52k stars 118 forks source link

SVGs don't render correctly on GitHub #25

Closed adius closed 6 years ago

adius commented 6 years ago

https://github.com/adius/svg-term-bug

This is a strange bug. The images look OK in every program I checked them, but not on GitHub.

I think the problem has either to do with GitHub sanitizing the SVGs (sanitize=true) or that they are loaded in an image tag. Altough the normal and the sanitized SVG code looks OK.

I think I remember that SVGs in images are treated as XML and otherwise as HTML and you're using some weird in code, which might be only allowed in HTML. But on the other hand the images in your projects seem to be OK .... 😩

marionebl commented 6 years ago

This is related to GitHub sanitizing SVG files. You can work around this by using rawgit:

https://cdn.rawgit.com/adius/svg-term-bug/afa571c1/bug.svg

This is a duplicate of #5, let's move any further discussion there.

adius commented 6 years ago

Oh, I see, thanks. Should have searched more properly for existing issues 🙈