search

marionebl / svg-term-cli

Share terminal sessions via SVG and CSS
MIT License
3.48k stars 116 forks source link

Unnecessary padding at the top #34

Closed pksunkara closed 5 years ago

pksunkara commented 5 years ago

You can see the svg that has been created here which has unnecessary padding at the top. The command used is:

svg-term --cast 193115 --window --width 80 --height 20 --from 100

Can I know how to fix it? Thanks.

marionebl commented 5 years ago

This is a bug thats rooted in svg-term / load-asciicast where for some very wide casts there are issues with recalculating the width correctly.

You'll have better results when recording the cast with a width/height that resembles the intended format more closely

pksunkara commented 5 years ago

So, I have dug into this and pinpointed that the issue is with load-asciicast which is basically a wrapper around asciinema-player. I am going to go with strict terminal dimensions on my side. If anyone else comes across this and want to fix this, please create an issue on asciinema-player