search

marionettejs / backbone.marionette

The Backbone Framework
https://marionettejs.com
Other
7.06k stars 1.26k forks source link

Rename close to destroy / Region swap method #1074

Closed jamesplease closed 10 years ago

jamesplease commented 10 years ago

We can't forget about #801. It was closed because it was opened against an old v2.0 branch, which I deleted without realizing it would close the PRs opened against it (in hindsight it seems so obvious for me to have checked!)

That issue had two changes:

jasonLaster commented 10 years ago

Nice catch @jmeas.

ahumphreys87 commented 10 years ago

@jmeas @jasonLaster do you want region.swap logged against 1.7.x/1.8 or just for v2.0? I had actually pulled that function out of the original PR so can push against the current version if you guys want?

jamesplease commented 10 years ago

@ahumphreys87, awesome! Thanks so much for doing that! If you wanted to make it against 1.8 we could include it in that release.

ahumphreys87 commented 10 years ago

Just logged a PR for review :smile: https://github.com/marionettejs/backbone.marionette/pull/1076

ahumphreys87 commented 10 years ago

@jmeas this can probably be closed now, swap or rather preventClose has been merged into v1.8.0.

There is an open PR for close to destroy - which will be best left open for a while :wink: