search

marionettejs / backbone.marionette

The Backbone Framework
https://marionettejs.com
Other
7.07k stars 1.26k forks source link

Derick Bailey's Author Attribution #1234

Closed joezimjs closed 10 years ago

joezimjs commented 10 years ago
  1. In package.json and component.json, Derick Bailey is listed as the author and his web URL is listed as http://derickbailey.lostechies.com. You may want to verify that Derick doesn't want to switch this to his new blog URL.
  2. Derick is listed as the only author. From what I've seen in the past few months, I think several other people at least deserve "honorable mention" :)
paulovieira commented 10 years ago

Related to this issue, I suggest that the initial sentence in readme.md should be reviewed:

It is a collection of common design and implementation patterns found in the applications that I (Derick Bailey) have been building with Backbone

That was written when Marionette was mostly a one-man-effort, but that is not the case at all now!

samccone commented 10 years ago

This has all been addressed in the v2 branch https://github.com/marionettejs/backbone.marionette/commit/f00d0406bb8ae715bc69e973dfcaa053323850aa

thanks for pointing all of this out tho!

jamesplease commented 10 years ago

The initial post here references the package and component manifests, which haven't been updated to reflect anything in this post in v2

samccone commented 10 years ago

oops good catch @jmeas

jamesplease commented 10 years ago

@joezimjs, you're absolutely right that others contribute to the project, but I'm just worried about the effort required to keep the authors sections of these manifests in line with the contributors to the project. How should we even decide who an author is? Whether they're core or not? Active or not? Maybe base it off lines of code? None of these seem quite right. And I can't think of any rule by which it makes it easy to accurately communicate who the authors of Marionette are.

I think the most accurate value would be "Derick Bailey and the community," but I guess that isn't really possible with these manifests :)

Because of this, I'm fine leaving it as just Derick Bailey, I think.

samccone commented 10 years ago

:+1:

joezimjs commented 10 years ago

@jmeas, that only covers point 2. Was point 1 fully taken care of?

jamesplease commented 10 years ago

Oh man, sorry about that @joezimjs. I completely overlooked that. I blame the fact I wrote the response on my iPhone.

@samccone can you ask Derick about that sometime?

jamiebuilds commented 10 years ago

Also I'm pretty sure in component.json its supposed to be "url" not "web"

samccone commented 10 years ago

yep, we can switch it, this is really such a minor thing......

jamesplease commented 10 years ago

heh, yeah, it is definitely minor but it's good to be correct :)

jamesplease commented 10 years ago

@derickbailey would you like to update your website in the package.json file? If not I'm gonna close this issue

jamesplease commented 10 years ago

Gonna close. DB can reopen if he decides to update things.