search

marionettejs / backbone.marionette

The Backbone Framework
https://marionettejs.com
Other
7.07k stars 1.26k forks source link

Upgrade to backbone 1.4 #3657

Closed jaapz closed 5 years ago

jaapz commented 5 years ago

Backbone 1.4 has been released! Should marionette just work with this new version? Do we need a new marionette release? I see that the package.json pins the version to ~1.3.3, and I guess this means 1.4 is not yet supported?

Borming commented 5 years ago

Marionette should work out of the box with 1.4, it works for us.

paulfalgout commented 5 years ago

Marionette has backbone at a peer dependency, so 1.4.0 will work, however npm/yarn will give a peer dependency warning at install. As backbone has previously had breaking changes in minor updates, we'll probably keep it this way until things are ironed out or are clearly non-breaking. That said, other than the warning there's no reason I can see why using 1.4 wouldn't work now. At some point we'll want to update the peer dependency to include 1.4, but not increase it to remove previous versions.

jaapz commented 5 years ago

Ok, thanks! I'll update the dependency on my side then and see if it breaks in any unexpected ways.

noobiek commented 5 years ago

Hi,

I actually had a problem with this. When I did reinstall of all modules in project, BB 1.4 got installed (yes, i reinstalled without lock file), so Babysitter installed 1.3.3 as a peer dependency, which resulted in having two Backbones 1.3.3 and 1.4 - in some webpack modules it was 1.4 and in others 1.3.3.

So I had to force the 1.3.3 version of BB back and then reinstall Babysitter. So, would be nice to have dep version upped.

Thanks for the tools, anyway!

blikblum commented 5 years ago

From where babysitter is coming? It was removed long time ago

noobiek commented 5 years ago

Hi, Sorry for the confusion. I use the separate Babysitter module from npm. So yeah, I don't use Marionette (I wish I didn't miss it when I started the project 2+ years ago). I use Bb, Bs and Radio. Perhaps I should've posted this to the Babysitter repo, but I found this issue and didn't wan't to duplicate. Sorry again.