marionettejs / backbone.marionette

The Backbone Framework
https://marionettejs.com
Other
7.07k stars 1.26k forks source link

ui, events,regions selector doesn't scoped to current view #3715

Open m-ar13f opened 11 months ago

m-ar13f commented 11 months ago

When create layout using ui definition in view, it didn't scoped to the current view. It was kind useless when the selector select element outside the view, and this would introduce bug in the application. This also affected on regions definition, events an others definition that utilize selector inside view. For now i just select the element in the current view using backbone view this.$('selector') that will solve the problem and ignore all everything marionette view offers.

paulfalgout commented 5 months ago

I think we'd need an example of what you're talking about. as with backbone, things in marionette are related to the view's el. The ui is just looped through such that _this._ui[key] = _this.$(selector); So if this.$('selector') is working but this.ui.foo isn't.. you have some other issue.

https://github.com/marionettejs/backbone.marionette/blob/master/lib/backbone.marionette.esm.js#L822