undefined ES5 getters/setters broken again

marionettejs / marionette.inspector

:mag: Marionette Inspector - Explore your App

http://goo.gl/Wo3pju

MIT License

170 stars 42 forks source link

undefined ES5 getters/setters broken again #289

Open jklmli opened 9 years ago

jklmli commented 9 years ago

https://github.com/marionettejs/marionette.inspector/commit/8b35f9d5cf1626331243044d01a421095dd94891 overrode some of the fixes committed in https://github.com/marionettejs/marionette.inspector/commit/e869f18d13c636cd5d513cf30a189e38b1431f31

paulfalgout commented 9 years ago

Hmm.. I think some commenting is in order to prevent this from happening again. Or is there anyway we could accurately test this? Failing tests would be even better. Otherwise I could certainly see this happening again.

jasonLaster commented 9 years ago

Hmm, yea please submit a fix and comments or tests

blikblum commented 7 years ago

Anyone knows how to reproduce the issue, so i can add tests? @jiaweihli