search

marionettejs / marionettejs.com

:triangular_flag_on_post: Source files for the Marionette site
https://marionettejs.com
MIT License
26 stars 32 forks source link

Add task that converts SVG into data/image as part of build process #250

Open peterblazejewicz opened 9 years ago

peterblazejewicz commented 9 years ago

After recent revert: https://github.com/marionettejs/marionettejs.com/commit/740f3ce8bedbd80fad119dbd5ea0ea642441444b the source code has now inlined SVGs images for brand and branded text visible in above the fold section - which allowed us to completely solve problem with ATF topic: 20150215213443

This is fine - but we should figure out the way to automate conversion process from SVG source file: https://github.com/marionettejs/marionettejs.com/blob/master/src/images/marionette.svg into this one: https://github.com/marionettejs/marionettejs.com/blob/master/src/partials/_marionette_logo.jade

Ideally Grunt task. I've been using shell command:

echo -n `cat marionette-text.svg` | base64 | pbcopy

to manually create content.

samccone commented 9 years ago

:+1:

ingro commented 9 years ago

Maybe this can be a solution?

https://www.npmjs.com/package/grunt-datauri-variables

peterblazejewicz commented 9 years ago

@ingro Thanks! I'll look