search

marionettejs / marionettejs.com

:triangular_flag_on_post: Source files for the Marionette site
https://marionettejs.com
MIT License
26 stars 32 forks source link

docs for 1.7.0 do not build? #416

Open samccone opened 9 years ago

samccone commented 9 years ago

https://github.com/marionettejs/backbone.marionette/issues/2678

thanks for reporting @KarlPurk

paulfalgout commented 9 years ago

O.o so weird. The rest of em seem to work. Maybe just a deploy fail?

samccone commented 9 years ago

perhaps

peterblazejewicz commented 9 years ago

The link is incorrect, the correct one should be: http://marionettejs.com/docs/v1.7/ We need to check urls build routine :)

paulfalgout commented 9 years ago

Hmm I wonder why is this the case? 1.6.0 and 1.8.0 both use ".0"

samccone commented 9 years ago

https://github.com/marionettejs/marionettejs.com/blob/master/tasks/utils/tags.js#L4-L14

here we are :hear_no_evil:

peterblazejewicz commented 9 years ago

The version is tagged '1.7' - not '1.7.0': https://github.com/marionettejs/backbone.marionette/releases/tag/v1.7

edit: see above comment by @samccone

ahumphreys87 commented 9 years ago

Ah I remember this from the old site, there are a bunch of weirdly names tags if I remember rightly. Check out the ruby script :p I'm sure I has special cases for them

On Tuesday, 21 July 2015, Peter Blazejewicz notifications@github.com wrote:

The version is tagged '1.7' - not '1.7.0': https://github.com/marionettejs/backbone.marionette/releases/tag/v1.7

— Reply to this email directly or view it on GitHub https://github.com/marionettejs/marionettejs.com/issues/416#issuecomment-123459044 .