search

marionettejs / marionettejs.com

:triangular_flag_on_post: Source files for the Marionette site
https://marionettejs.com
MIT License
26 stars 32 forks source link

remove invalid tags for docs #450

Closed denar90 closed 8 years ago

denar90 commented 8 years ago

PR for issue #449

jdaudier commented 8 years ago

@denar90 Could you please fix the merge conflict? Thanks!

denar90 commented 8 years ago

fixed

ahumphreys87 commented 8 years ago

do we not want to keep the docs for up coming pre releases? Maybe just ensure they are not the default selected version - i.e. current should be latest stable version

denar90 commented 8 years ago

Do we need pre releases in doc? Maybe cut them at all, if we have some really good doc in pre release we can include it (e.g. v3.0.0-pre.4). Because now all v3-pre with not finished doc and people are really confused.

denar90 commented 8 years ago

@ahumphreys87 what whould you suggest, just set current version to v2.4.5 ?

ahumphreys87 commented 8 years ago

Yeah I think that is best

On Wednesday, May 11, 2016, Artem Denysov notifications@github.com wrote:

@ahumphreys87 https://github.com/ahumphreys87 what whould you suggest, just set current version to v2.4.5 ?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/marionettejs/marionettejs.com/pull/450#issuecomment-218542534

denar90 commented 8 years ago

@ahumphreys87 added fix. It really make sense to store all tags and only change current version.

ahumphreys87 commented 8 years ago

💃 great work @denar90

👍

jdaudier commented 8 years ago

Thanks for the help @denar90!

samccone commented 8 years ago

boom nice work @denar90

denar90 commented 8 years ago

Thank you guys :)