search

marionettejs / marionettejs.com

:triangular_flag_on_post: Source files for the Marionette site
https://marionettejs.com
MIT License
26 stars 32 forks source link

Move general css styles into separate repo #483

Open denar90 opened 8 years ago

denar90 commented 8 years ago

I propose to move global css styles in separate repo. As a result we will have kinda framework which can be used for main site and for blog. Stuff which can be moved:

Thoughts?

peterblazejewicz commented 8 years ago

Some changes to SCSS structure were loosely based on SASS Guidelines pattern: https://sass-guidelin.es/#the-7-1-pattern How do you want to incorporate site and blog changes? Do you think the themes could be used for this?

scott-w commented 8 years ago

I totally support this. It'd be great if we can use an explicit license too so people can build plug-ins that have a clear reference point back to Marionette.

denar90 commented 8 years ago

@peterblazejewicz which styles can we use in themes files? Regarding to https://github.com/marionettejs/blog/issues/17 we should make them both in one theme style. So right now I have no clue what to place there...

@scott-w sorry, are you talking about js plugins? Do you wanna people who build Mn plugins use our styles for their doc sites?

scott-w commented 8 years ago

For stuff we'd want to bring into the ecosystem or affiliate with Marionette.

peterblazejewicz commented 8 years ago

@peterblazejewicz which styles can we use in themes files? Regarding to marionettejs/blog#17 we should make them both in one theme style. So right now I have no clue what to place there...

All common should go into abstracts/base and themes. Have you though about snipping common Sass just NPM or Bower GitHub based dependency? It could be installed just like any other dependency and used in site and blog Sass code: The Zurb's Foundation installs Sass sources as Bower dependency that are later configured to be included in Sass configuration: http://foundation.zurb.com/

# RUBY
# Require any additional compass plugins here.
add_import_path "bower_components/foundation/scss"
// Node/Grunt
sass: {
      options: {
        includePaths: ['bower_components/foundation/scss']
      },
      dist: {
        options: {
          outputStyle: 'compressed',
          sourceMap: true,
        },
        files: {
          'css/app.css': 'scss/app.scss'
        }
      }
    },
denar90 commented 8 years ago

@scott-w thanks, got it 👍 @peterblazejewicz yeah, was thinking to do it in similar way, but was frustrated by themes folder.

I'll try to create some repo maybe we can review it and talk about structure and all stuff in it.