search

marionettejs / marionettejs.com

:triangular_flag_on_post: Source files for the Marionette site
https://marionettejs.com
MIT License
26 stars 32 forks source link

Improve contrast ratio #495

Open denar90 opened 7 years ago

denar90 commented 7 years ago

We have not so good contrast ratio. Using e.g. Lighthouse, we have these results

image

P.S.

https://chrome.google.com/webstore/detail/chromelens/idikgljglpfilbhaboonnpnnincjhjkd http://leaverou.github.io/contrast-ratio/

might help to improve it

peterblazejewicz commented 7 years ago

This extension (from Google) adds an option to audits section in dev tools to verify a11y rules. It procies hinted color that should be used instead of one failing tests based on luminosity change. So you could do adjustment pretty mach based on this tool hints: https://chrome.google.com/webstore/detail/accessibility-developer-t/fpkknkljclfencbdbgkenhalefipecmb?hl=en The footer is secondary content (always hidden under the fold), so this should be OK to just fix color using hints (for links) The masthead buttons background color is the other thing. Just check what you get with a11y tool

denar90 commented 7 years ago

thx 👍

paulfalgout commented 7 years ago

I think we should just ask @samccone to tweak lighthouse so marionettejs.com passes. :1st_place_medal:

samccone commented 7 years ago

:) thanks @peterblazejewicz for the detailed response. in this case I think no magic lighthouse hacks are needed :P