search

marionettejs / marionettejs.com

:triangular_flag_on_post: Source files for the Marionette site
https://marionettejs.com
MIT License
26 stars 32 forks source link

Deploy build is broken #499

Closed denar90 closed 5 years ago

denar90 commented 7 years ago

I dunno why but build for deploying stuff is broken - https://travis-ci.org/marionettejs/marionettejs.com/builds/220112384

Everything built fine until script wanna init git, add files and push all stuff to gh-pages.

Last time I did deploy manually using ship.sh script.

denar90 commented 7 years ago

So I made pushing stuff in travis-runner.sh kinda same as ship.sh and now error say smth we can think about https://travis-ci.org/marionettejs/marionettejs.com/builds/230931875#L1268

remote: Invalid username or password.
fatal: Authentication failed for 'https://[secure]@github.com/marionettejs/marionettejs.com.git/'
paulfalgout commented 7 years ago

Fixed the deploy by redoing the gh_token, but now it won't compile the docs

denar90 commented 7 years ago

I suppose it's because of https://github.com/marionettejs/marionettejs.com/commit/1bb5e1754e87f5c2f4aff4b4625d079ec99061f0#diff-354f30a63fb0907d4ad57269548329e3L15 we should either bring back yarn or add npm i

paulfalgout commented 7 years ago

yarn was being called twice as travis will install it or call it automatically.

paulfalgout commented 7 years ago

Pretty sure the travis script's GH_TOKEN was getting overwritten by:

Setting environment variables from .travis.yml
$ export GIT_NAME=[secure]
$ export GIT_EMAIL=[secure]
$ export GH_TOKEN=[secure]

When I renamed the one in travis to GITHUB_TOKEN the script started working, but the docs wouldn't compile

paulfalgout commented 7 years ago

I re-added GH_TOKEN a duplicate of GITHUB_TOKEN to travis, but no change.. All I'm getting now is:

Running "gitty:checkoutTag:marionette" (gitty:checkoutTag) task
>> Tag Checked out! -- undefined
paulfalgout commented 7 years ago

I definitely think this issue is related to the GH info being added in this env var: https://github.com/marionettejs/marionettejs.com/blob/master/.travis.yml#L6 in addition to being set in travis itself.

Note I also put back yarn getting called and installed twice.

But I did get a local deploy to finally work correctly.

denar90 commented 7 years ago

I've been told that gh retrieved tokens after some security leak or smth. But I dunno why token generated by me won't work...

So, can we close this one?

paulfalgout commented 5 years ago

Out of all of the things currently broken on the website, this is not one :-)