search

marionnewlevant / craft-snitch

Craft plugin. Report when two people might be editing the same entry, category, or global
MIT License
35 stars 16 forks source link

froala install error after update #12

Closed jlamb1 closed 5 years ago

jlamb1 commented 5 years ago

I think related to #11, updating the snitch plugin brings down my local env with the error Call to a member function getSettings() on null.

I had this error originally when I had both Froala WYSIWYG Editor installed in tandem with the two-factor authentication plugin. I uninstalled the two-factor plugin and everything started working.

I saw this error pop back up again today after updating snitch, more details & stacktrace here:

https://github.com/froala/Craft-3-Froala-WYSIWYG/issues/11

I'm not sure if this is on your end or theirs, but wanted to bring it to your attention - the common denominator seems to be the two-factor plugin

marionnewlevant commented 5 years ago

What Snitch is doing is calling Craft::$app->getUser()->getIsGuest() which is getting the custom fields, which calls the froala Field->init() before the froala module is loaded.

Problem on their end, but doesn't look intractable

jlamb1 commented 5 years ago

thanks @marionnewlevant ! This lines up with the PR i'm seeing, so makes sense https://github.com/froala/Craft-3-Froala-WYSIWYG/pull/12