marioortizmanero / polybar-pulseaudio-control

A feature-full Polybar module to control PulseAudio
MIT License
471 stars 49 forks source link

Consider using arguments to configure the module, rather than constants inside the script #26

Closed marioortizmanero closed 3 years ago

marioortizmanero commented 4 years ago

It might be a good idea to use arguments rather than constants at the top of the script. For example SINK_BLACKLIST=(a b c) would become --sink-blacklist a --sink-blacklist b --sink-blacklist c or --sink-blacklist a,b,c.

There are of course downsides and upsides to this:

Pros

Cons

marioortizmanero commented 3 years ago

This can now be closed with #34, thanks to @OJFord!