It might be a good idea to use arguments rather than constants at the top of the script. For example SINK_BLACKLIST=(a b c) would become --sink-blacklist a --sink-blacklist b --sink-blacklist c or --sink-blacklist a,b,c.
There are of course downsides and upsides to this:
Pros
Using arguments would make it possible to have multiple Polybar modules with a single script. This doesn't really make sense with the current behavior, but if #25 is implemented it would be less troublesome to configure it for both sinks and microphones.
Using arguments is more user friendly and manageable than modifying the script, I'd say. It's also easier to update the script because you can just replace it.
Cons
Using parameters would imply repetition, as the script would need to be configured whenever it's called. The polybar module would be harder to manage and configure. It would mean long and repetitive commands for each keybinding.
It might be a good idea to use arguments rather than constants at the top of the script. For example
SINK_BLACKLIST=(a b c)
would become--sink-blacklist a --sink-blacklist b --sink-blacklist c
or--sink-blacklist a,b,c
.There are of course downsides and upsides to this:
Pros
Using arguments would make it possible to have multiple Polybar modules with a single script. This doesn't really make sense with the current behavior, but if #25 is implemented it would be less troublesome to configure it for both sinks and microphones.
Using arguments is more user friendly and manageable than modifying the script, I'd say. It's also easier to update the script because you can just replace it.
Cons