Add active port to Sink Name

ninjawithaneedle commented 4 years ago

Pulse audio can have multiple ports per sink. If you plug in headphones, it uses the same sink with a different port. This change will add the active port to the sink like below.

alsa_output.pci-0000_00_1f.3.analog-stereo/analog-output-speaker
bluez_sink.04_5D_4B_65_F7_1F.a2dp_sink/headset-output

With this, it is possible to have different sink nickname for when a wired headphone is connected.

marioortizmanero commented 3 years ago

Hey @ninjawithaneedle are you going to have time to finish this? Please let me know, or I will take over the PR and finish it myself.

samyak-jain commented 3 years ago

Hey @marioortizmanero, any idea on what's left to complete in this PR? I can try lending a hand.

marioortizmanero commented 3 years ago

Hi! This is a list of what's needed more or less:

This is based on code from pre-v2.0, so the documentation should be in the argument parser help message instead of the table. The documentation part has to be discussed, I'm not sure what's the easiest way to make it user-friendly. You'll have to do a merge with master to avoid any issues.
I would like support for both sinkname and sinkname/port. I think this used sinkname/ and sinkname/port, but the former is better because it maintains backward compatibility and doesn't require knowing about this feature.
Not sure what else, if you create a new PR I can review your code and we can discuss the changes in there. If you have any doubts/concerns let me know.

marioortizmanero commented 3 years ago

Now that #43 has been merged this can be closed.

marioortizmanero / polybar-pulseaudio-control

Add active port to Sink Name #32