There are many parts of the code that could do with a bit of cleaning up. I would very much appreciate any help on this, I can help out by reviewing any changes:
[ ] The script includes multiple ways of reading properties:
With a while read in getNicknameFromProp
With a good ol' grep pipe everywhere else
The first actually seems more robust, but the second is more "bash"-y. I don't really care, anyway. The point is that they should be consistent.
[ ] getNickname is quite messy. The if statements could surely be simplified in some way. Or it should be commented internally, at least.
[ ] Overall, many commands are incredibly large and complicated. We could:
Split each pipe into a different line with \ so that it's more readable
Try to simplify them
[ ] Put all the simple getter functions at the beginning of the file
If anyone else thinks of other improvements, please leave them as a comment here!
There are many parts of the code that could do with a bit of cleaning up. I would very much appreciate any help on this, I can help out by reviewing any changes:
[ ] The script includes multiple ways of reading properties:
while readingetNicknameFromPropgreppipe everywhere elseThe first actually seems more robust, but the second is more "bash"-y. I don't really care, anyway. The point is that they should be consistent.
getNicknameis quite messy. Theifstatements could surely be simplified in some way. Or it should be commented internally, at least.\so that it's more readableIf anyone else thinks of other improvements, please leave them as a comment here!