marioortizmanero / polybar-pulseaudio-control

A feature-full Polybar module to control PulseAudio
MIT License
482 stars 50 forks source link

Fix argument parsing #66

Closed marioortizmanero closed 2 years ago

marioortizmanero commented 2 years ago

This should close #63

Aerion commented 2 years ago

Thanks for the swift response.

The original command is now fixed, but it seems to have introduced a regression:

# No errors expected
$ ./pulseaudio-control.bash --osd --icons-volume "A"
Unrecognised action: A
# This works great though!
./pulseaudio-control.bash --osd output
64% Sink #89
marioortizmanero commented 2 years ago

Ah, whoops. Looks like shift modifies the function's arguments instead of the global arguments. Not the prettiest, but it should be fixed now.

Aerion commented 2 years ago

Sweet, looks good!