Closed lovetoburnswhen closed 1 year ago
Hey @mariorodeghiero - would you be able to promote it..?
@nirfuzz and @lovetoburnswhen can you paste a python repository mentioning where the piece of code contains this? so I can follow it as an example. Also, feel free to send PR's with the changes if you want, I really need code contributors.
✅ Added support on V2 branch, this issue will be closed soon.
@nirfuzz @lovetoburnswhen V2 is available, you can check the list of improvements here v2
About string.quoted.docstring
can you provide some python code that I can have a look at and try to improve the colors a bit? I will focus on the docstring now.
imports look great, though now there seems to be some inconsistency in string highlighting (not only docstring):
and another inconsistency with modules / methods:
plus - no different colors for nested parentheses.
@mariorodeghiero
@nirfuzz thanks for letting me know, I will check it.
@nirfuzz I pushed a v2.0.1 with some Python support.
I will try to review a bit more once I have some time available(Now I am focused to improve the current colors) but for a while I think is ok. I just pull an open-source python project and I added some support.
Note: about no different colors for nested parentheses, I think is better that way for working with javascript, I tried some colors but I didn't like them.
A few scopes I noticed were missing:
keyword.control.import
string.quoted.docstring