mariorodeghiero / vue-theme-vscode

+577.000 installs ⬇️ Theme for Visual Studio Code inspired by Vue.js, with support for more popular languages, trying to maintain a perfect harmony of colors.
https://mariorodeghiero.github.io/vue-theme/
MIT License
75 stars 14 forks source link

Improve Python Colors #11

Closed lovetoburnswhen closed 1 year ago

lovetoburnswhen commented 2 years ago

A few scopes I noticed were missing:

nirfuzz commented 2 years ago

Hey @mariorodeghiero - would you be able to promote it..?

mariorodeghiero commented 2 years ago

@nirfuzz and @lovetoburnswhen can you paste a python repository mentioning where the piece of code contains this? so I can follow it as an example. Also, feel free to send PR's with the changes if you want, I really need code contributors.

mariorodeghiero commented 2 years ago

✅ Added support on V2 branch, this issue will be closed soon.

mariorodeghiero commented 2 years ago

@nirfuzz @lovetoburnswhen V2 is available, you can check the list of improvements here v2

About string.quoted.docstring can you provide some python code that I can have a look at and try to improve the colors a bit? I will focus on the docstring now.

nirfuzz commented 2 years ago

imports look great, though now there seems to be some inconsistency in string highlighting (not only docstring):

image

and another inconsistency with modules / methods:

image

plus - no different colors for nested parentheses.

@mariorodeghiero

mariorodeghiero commented 1 year ago

@nirfuzz thanks for letting me know, I will check it.

mariorodeghiero commented 1 year ago

@nirfuzz I pushed a v2.0.1 with some Python support.

I will try to review a bit more once I have some time available(Now I am focused to improve the current colors) but for a while I think is ok. I just pull an open-source python project and I added some support.

Note: about no different colors for nested parentheses, I think is better that way for working with javascript, I tried some colors but I didn't like them.

Screenshot 2022-10-12 at 22 07 39