Add missing methods changeXXX to some properties to have a more consistent API accross properties. - Githubissues

mariosimao / notion-sdk-php

A complete Notion SDK for PHP developers.

https://mariosimao.github.io/notion-sdk-php/

MIT License

138 stars 24 forks source link

Add missing methods changeXXX to some properties to have a more consistent API accross properties. #342

Closed ren0v closed 4 months ago

ren0v commented 5 months ago

Most Pages/Properties classes have a changeXXX method but some properties don't. This PR add a changeXXX property to the following classes

Pages/Properties/Date : changeDate
Pages/Properties/MultiSelect : changeOptions
Pages/Properties/Status : changeOption (same as Select)

A changeName is also added to the Databases/Properties/StatusOption class as it already exists on the SelectOption class.

ren0v commented 4 months ago

@mariosimao hi Mario, i opened 2 PR on the repo. Let me know if you need more details or corrections to accept those PR.