search

mariotoffia / FluentDocker

Use docker, docker-compose local and remote in tests and your .NET core/full framework apps via a FluentAPI
Apache License 2.0
1.31k stars 97 forks source link

Parse more defensively #302

Closed Rory-Reid closed 11 months ago

Rory-Reid commented 11 months ago

I'm opening this with the full belief that these changes are far too destructive and opinionated to actually be worth merging in. This PR exists to document and demonstrate the pain points I had trying to make FluentDocker work with Podman (v 4.6.2 at the time of writing), and maybe help break the ice for #300.

It feels like Podman is too dissimilar from docker for this library to faithfully support it, or without breaking and losing the ability to directly invoke docker network ls and docker top via this library (possibly other commands too).

I think if there was an interest in actively supporting podman in its current form with this library, the changes I've made to parsing network ls and top should instead try to parse as much detail as possible, safely. I wouldn't mind trying to tackle that myself, but I figure there's no point me spending time on it if there is no desire to support the quirks and differences of podman in FluentDocker today.

Thanks for reading and thank you for this great tool.

Rory-Reid commented 11 months ago

Changed my mind actually, it's not that much more effort to submit something cleaner and non-destructive.