search

mariotoffia / FluentDocker

Use docker, docker-compose local and remote in tests and your .NET core/full framework apps via a FluentAPI
Apache License 2.0
1.31k stars 97 forks source link

Parsing changes for podman support #303

Open Rory-Reid opened 11 months ago

Rory-Reid commented 11 months ago

This is a summary of issues I have worked on in order to get closer to an initial pass for supporting podman (#300)

I've tried to do them as podman-agnostic as possible (more general defensive approaches to parsing slightly different formats of things) but it's a non-zero amount of complexity added now for this. I understand if that's not something you'd be interested in bringing into the library.

mariotoffia commented 10 months ago

Hi @Rory-Reid and many thanks for this excellent PR!!

It seems to fail in two tests, I currently do not have the time to check why? Could you have a quick check and see if it is the current implementation affecting it?

Cheers, Mario :)

Rory-Reid commented 10 months ago

Hi @mariotoffia and firstly thanks for looking at my PR! I appreciate it's not a small one!

Ah, yeah, this is the same two tests that are failing on the master branch as far as I can see - PullContainerBeforeRunningShallWork and ContainerHealthCheckShallWork.

Both of these passed locally for me so I assumed it was environmental and wasn't familiar with the CI setup but on rerun I can see they pass with an error in my logs because I don't have docker-machine ("Failed to find docker-machine client binary - please add it to your path").

Given they're currently failing on master I don't think they're related to my changes but I was purposefully leaving this PR as a draft until I could rebase onto a working build to prove that. I'll see if I can prove anything locally at least around this sometime soon.